fix(load examples): load examples creating unnecessary main database#12351
Merged
dpgaspar merged 2 commits intoapache:masterfrom Jan 8, 2021
Merged
fix(load examples): load examples creating unnecessary main database#12351dpgaspar merged 2 commits intoapache:masterfrom
dpgaspar merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12351 +/- ##
==========================================
- Coverage 67.05% 62.80% -4.26%
==========================================
Files 1001 1014 +13
Lines 49380 49494 +114
Branches 5033 5070 +37
==========================================
- Hits 33112 31083 -2029
- Misses 16140 18202 +2062
- Partials 128 209 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
| # reuse session when loading data if possible, to make import atomic | ||
| if example_database.sqlalchemy_uri == get_main_database().sqlalchemy_uri: | ||
| if example_database.sqlalchemy_uri == get_example_database().sqlalchemy_uri: |
Member
There was a problem hiding this comment.
@dpgaspar this condition will always be true, and causes the example data to be loaded into the main database instead of the examples databases (because it always reuses session.connection().
betodealmeida
added a commit
to betodealmeida/incubator-superset
that referenced
this pull request
Jan 22, 2021
…atabase (apache#12351)" This reverts commit f354bb3.
This was referenced Jan 22, 2021
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Load examples is creating unnecessary
maindatabase connection recordADDITIONAL INFORMATION